Deflake amp-form tests #9384
Merged
Deflake amp-form tests #9384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghassemi
reviewed
May 16, 2017
| const message = 'Failed to parse response JSON:'; | ||
| user().error(TAG, message, error); | ||
| rethrowAsync(message, error); | ||
| user().error(TAG, `Failed to parse response JSON: ${error}`); |
There was a problem hiding this comment.
- @jridgewell
Carlos, Justin:
do we know why did we hadrethrowAsynchere?
There was a problem hiding this comment.
My theory is it was originally there to throw the error outside of the Promise chain so it would show up in the console. Since user().error performs that function too, it was equivalent.
aghassemi
reviewed
May 16, 2017
| return timer.promise(5).then(() => { | ||
|
|
||
| return ampForm.xhrSubmitPromiseForTesting().then(() => { | ||
| expect(false).to.be.true; // should not run |
There was a problem hiding this comment.
assert.fail('submit should have failed.');
ditto above.
There was a problem hiding this comment.
Ah I was looking for the right fail pattern, thanks.
There was a problem hiding this comment.
Throwing a plain error is concise, but assert seems more idiomatic for Chai. Any objections to using assert?
aghassemi
approved these changes
May 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9358